dellemc-openmanage-ansible-modules
dellemc-openmanage-ansible-modules copied to clipboard
Add missing scp_component options to idrac_server_config_profile
depends on dell/omsdk#23
SUMMARY
add missing scp_component options to idrac_server_config_profile First step for #342
ISSUE TYPE
- Feature Pull Request
COMPONENT NAME
idrac_server_config_profile
ISSUES
References but does not fix #342
OUTPUT
no test cases changed, currently only testcases for idrac scp_component exist
ADDITIONAL INFORMATION
Forgot to add signoff as requested in dco, I would consider this a very minor update though :)
During my testing (scp_component eventfilters) I noticed that scp does not properly apply when using:
shutdown_type: NoReboot
it leads to the apply job being paused with 20% with message "SYS296: No reboot Server Configuration Profile Import job scheduled, Waiting for System Reboot to complete the operation."
When using:
shutdown_type: Graceful
the scp is job is being executed properly, the system is not rebooted. I am guessing this is not an ansible issue but how the idrac works. Should this be reported to Dell or is this viewed as a documentation only issue?
@anupamaloke who would I contact about the problem with shutdown_type: NoReboot
from comment https://github.com/dell/dellemc-openmanage-ansible-modules/pull/343#issuecomment-981111762 ? Should that be handled in a support case?
@anupamaloke who would I contact about the problem with
shutdown_type: NoReboot
from comment #343 (comment) ? Should that be handled in a support case?
@Klaas-, as per the iDRAC documentation, this is the correct behaviour. Following is what the iDRAC documentation says:
Shutdown : Select one of the following options:
NOTE: If No Reboot option is selected, no configuration changes will get applied for the SCP import job until the next manual server reboot.
- Graceful
- Forced
- No Reboot (Manually Reboot System)
In your playbook, since you set the shutdown_type
to NoReboot
, the import SCP job was waiting for the server reboot to happen before it could be applied. By default, it is Graceful
so that iDRAC will gracefully reboot the server (without manual intervention) if a server reboot is at all needed for certain configuration.
hmm okay, I think I'll PR something for the docs of the ansible module then. But that also means there is no "do not reboot" option? and I need to check somehow if graceful will reboot the server or not
Can one of the admins verify this patch?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2f88383
) 81.03% compared to head (88f715f
) 81.03%.
Additional details and impacted files
@@ Coverage Diff @@
## collections #343 +/- ##
============================================
Coverage 81.03% 81.03%
============================================
Files 191 191
Lines 30299 30299
Branches 4777 4777
============================================
Hits 24552 24552
Misses 5069 5069
Partials 678 678
Flag | Coverage Δ | |
---|---|---|
units | 81.00% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
plugins/modules/idrac_server_config_profile.py | 12.70% <ø> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @sachin-apa I don't think this is mergeable without the PR in https://github.com/dell/omsdk/pull/23
At least that is what I wrote ~2 years ago in https://github.com/dell/dellemc-openmanage-ansible-modules/pull/343#issue-1065034585
Hi @sachin-apa I don't think this is mergeable without the PR in dell/omsdk#23
@Klaas- this module has evolved over 2 years !! it is now independent of omsdk, we have few more enhancement planned in this month, we will merge this PR and add those enhancements/fixes on top of it..
Hi @sachin-apa I don't think this is mergeable without the PR in dell/omsdk#23
@Klaas- this module has evolved over 2 years !! it is now independent of omsdk, we have few more enhancement planned in this month, we will merge this PR and add those enhancements/fixes on top of it..
That's good to hear, I haven't followed it closely I have to admit :) I guess I'll just strike the reference from the initial comment then