csm icon indicating copy to clipboard operation
csm copied to clipboard

[FEATURE]: Improve karavi-metrics logs to display the number of pulled metrics

Open coulof opened this issue 4 years ago • 3 comments

Describe the solution you'd like Current logs give time to collect and push data :

2021/01/12 10:47:04 Looking up system ID 31ba0b0125517f0f Name powerflex01
2021/01/12 10:47:04 gatherMetrics took 2.25µs
2021/01/12 10:47:04 pushMetrics took 812ns
2021/01/12 10:47:04 GetSDCStatistics took 22.456348ms
2021/01/12 10:47:04 gatherPoolStatistics took 3.107µs
2021/01/12 10:47:04 pushPoolStatistics took 1.026µs
2021/01/12 10:47:04 gatherPoolStatistics took 1.742µs
2021/01/12 10:47:04 pushPoolStatistics took 729ns
2021/01/12 10:47:04 GetStoragePoolStatistics took 49.552945ms

While debugging an issue with the otel-collector, I was unsure of the actual metrics pushed.

Is it possible to add to this log the number of pulled/pushed metrics. For example:

2021/01/12 10:47:04 gatherMetrics XXX took 2.25µs

where XXX is the number of metrics.

coulof avatar Jan 12 '21 11:01 coulof

@coulof: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at [email protected].

ioeicicdsvc avatar Jan 12 '21 11:01 ioeicicdsvc

Keeping as a low priority and will address in a future release.

gallacher avatar Feb 16 '21 13:02 gallacher

Adding the "help wanted" label to solicit help from the community to help with contributions for this feature.

gallacher avatar May 19 '21 16:05 gallacher