ansible-powermax icon indicating copy to clipboard operation
ansible-powermax copied to clipboard

Update portgroup.py

Open smitty-dell opened this issue 1 year ago • 2 comments

Added the NVMe_FC option

Description

Added the option for NVMe_FC as a port group option like in the GUI.

GitHub Issues

List the GitHub issues impacted by this PR: N/A

GitHub Issue #

Checklist:

  • [x] I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • [ ] I have performed Ansible Sanity test using --docker default
  • [x] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have not allowed coverage numbers to degenerate
  • [x] I have maintained at least 90% code coverage
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] Backward compatibility is not broken

How Has This Been Tested?

We have a Powermax 2500 in the lab that we used to confirm this change worked as expected.

  • [x] We had all ports on the array set to NVMe/FC and then created a portgroup with the new choice and it configured the portgroup as expected with the proper director and ports.

smitty-dell avatar Oct 01 '24 15:10 smitty-dell

Waiting for the hardware availability to pick the PR.

sachin-apa avatar Nov 11 '24 13:11 sachin-apa

Can one of the admins verify this patch?

ansible-collections-svc avatar Jan 21 '25 11:01 ansible-collections-svc