ansible-powerflex icon indicating copy to clipboard operation
ansible-powerflex copied to clipboard

Adding support for Storage pool enhancements

Open trisha-dell opened this issue 1 year ago • 2 comments

Description

Adding support for parameters for Storage pool.

Checklist:

  • [X] I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • [X] I have performed Ansible Sanity test using --docker default
  • [X] I have verified that new and existing unit tests pass locally with my changes
  • [X] I have not allowed coverage numbers to degenerate
  • [X] I have maintained at least 90% code coverage
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • [X] Functional testing
  • [X] Unit testing

trisha-dell avatar May 14 '24 16:05 trisha-dell

Can one of the admins verify this patch?

ansible-collections-svc avatar May 14 '24 16:05 ansible-collections-svc

Codecov Report

Attention: Patch coverage is 68.47291% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 90.36%. Comparing base (0df06dd) to head (c71e68b). Report is 24 commits behind head on main.

Files Patch % Lines
plugins/modules/storagepool.py 66.04% 90 Missing and 38 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   91.71%   90.36%   -1.36%     
==========================================
  Files          49       49              
  Lines        6871     7078     +207     
  Branches      855      919      +64     
==========================================
+ Hits         6302     6396      +94     
- Misses        316      398      +82     
- Partials      253      284      +31     
Flag Coverage Δ
units 90.36% <68.47%> (-1.36%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 19 '24 08:05 codecov-commenter

run e2e

sachin-apa avatar May 23 '24 05:05 sachin-apa