helm-charts
helm-charts copied to clipboard
[stable/cloudhealth-collector] Use correct `secretKeyRef.key` for API Token secret
Description
- If a user installs this chart and sets the
api_token
value, the cloudhealth-colllector pod will fail to start due to the deployment config using the wrong secret key: - https://github.com/deliveryhero/helm-charts/blob/master/stable/cloudhealth-collector/templates/deployment.yaml#L50
- https://github.com/deliveryhero/helm-charts/blob/master/stable/cloudhealth-collector/templates/secret.yaml#L10
Checklist
- [x] Title of the PR starts with chart name (e.g.
[stable/mychartname]
) - [x] I have read the contribution instructions, bumped chart version and regenerated the docs
- [ ] Github actions are passing
Hi @jacobboykin 👋
Since the real environment variable that is used by Cloudhealth is called CHT_API_TOKEN
, how about we rename all references to api_token
? I think this would be more logical and consistent, right?
Also, you need to bump the chart version and update the chart readme from the templates 🙂
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.