helm icon indicating copy to clipboard operation
helm copied to clipboard

Published 20 hours ago • verified publisher icon deliverybot

Add input params

Open riker09 opened this issue 4 years ago • 5 comments

Please note: I didn't add the remove_canary input parameter to the action.yml because it was not documented in the README.md.

riker09 avatar Jun 09 '20 12:06 riker09

I think after I merged the other CR's seeing a conflict now, I was going to resolve but I wasn't quite sure which parameters were being kept as required.

colinjfw avatar Jul 14 '20 04:07 colinjfw

Sorry, I totally forgot about this PR. Should be all good now. But I'll keep on working on this GitHub action.

riker09 avatar Jul 27 '20 06:07 riker09

Is there a due to this PR to be merged?

assaf-grth avatar Nov 25 '20 08:11 assaf-grth

Would be great to fix this, since the warnings in the github actions log are very frustrating, making me wonder if I had the most recent version as described in the README.

This PR changes the inputs to chart-version from chart_version, which if fine and more consistent. Also, index.js replaces the _ with - so reading the values would totally work and really avoid frustration.

If I can do anything to help let me know!

romnn avatar Jan 13 '21 13:01 romnn

@riker09 can you also add repository in the action.yaml, it is already added in the index.js

DenisDuev avatar Mar 12 '21 07:03 DenisDuev