wp-migrate-db-anonymization icon indicating copy to clipboard operation
wp-migrate-db-anonymization copied to clipboard

Remove .gitignore during wp.org plugin build

Open kliqks opened this issue 6 years ago • 3 comments

I don't know when it happened, but it appears that /vendor is added to the gitignore. At least in my deployment, this makes the entire vendor folder not added to the commit and therefore, I imagine the whole plugin will fail to work. As a matter of fact, the vendor folder appears to be missing from this repo as well.

kliqks avatar Jun 27 '18 16:06 kliqks

@kliqks I don't commit the vendor directory here, but package it with the build that does to the WordPress repo. I clarified that here with install instructions: https://github.com/deliciousbrains/wp-migrate-db-anonymization#installation

polevaultweb avatar Jun 27 '18 17:06 polevaultweb

@polevaultweb That's cool, but the gitignore with the /vendor line will keep people that use the plugin from the WordPress plugin store from committing that folder in their own repo's. Seriously, I might be the only one doing it this way, but it's how I need to do it for my AWS High Availability sites. For git purposes, maybe this needs to be included in your .git/info/exclude file instead of using the gitignore. Thank you though, I love this plugin.

kliqks avatar Jun 27 '18 18:06 kliqks

@kliqks good point, but that is an edge case. I'll look at removing the .gitignore for the build. Any reason you aren't using Composer to manage the plugins, that way they stay out of your git repos? https://deliciousbrains.com/using-composer-manage-wordpress-themes-plugins/

polevaultweb avatar Jun 27 '18 19:06 polevaultweb