offliner icon indicating copy to clipboard operation
offliner copied to clipboard

Published 20 hours ago • verified publisher icon delapuente

Communication enhancements

Open delapuente opened this issue 9 years ago • 3 comments

This closes #8 , closes #7 , closes #6 and closes #5 . @mykmelez or @marco-c , do you want to take a look for a second opinion before merging? Thanks!

PS: You should pay attention to files under /src as everything else is autogenerated.

delapuente avatar Nov 05 '15 00:11 delapuente

I'll take a look tomorrow! I'm interested to see how offliner works, a review seems a good/useful way to start looking into it.

marco-c avatar Nov 05 '15 00:11 marco-c

Looks good to me, only nits. I obviously don't have enough knowledge about offliner to give the best possible review, but I think the changes proposed do actually fix the issues outlined in the first comment.

marco-c avatar Nov 05 '15 19:11 marco-c

Looks good to me too. Like Marco, I don't have a good sense of this codebase yet, but the changes seem straightforward.

mykmelez avatar Nov 05 '15 21:11 mykmelez