three.net icon indicating copy to clipboard operation
three.net copied to clipboard

Migrate away from MSBuild-based NuGet package restore and Missing 'KeyModifiers'

Open aloisdg opened this issue 10 years ago • 7 comments

Hello,

I have trouble to build the project on VS2013. It seems that you are using the old version of nuget, right? Can we move to the updated version?

I start the migration and everything works until I get an error with Pencil.Gaming : KeyModifiers:

Error 1 The type or namespace name 'KeyModifiers' could not be found (are you missing a using directive or an assembly reference?)

The Pencil.Gaming.GLW3 should contains it, doesn't it?

aloisdg avatar May 27 '15 21:05 aloisdg

It appears to run for me using VS2013, though I had VS2015 installed at home, I can try on my laptop to double check that it runs in VS2013.

Pencil.Gaming at least at this time doesn't have a NuGet package for its builds. Can you try rebuilding the Pencil.Gaming from source and copying the library reference into Three.Net?

I was using the NuGet installed with 2013.

delaneyj avatar May 27 '15 21:05 delaneyj

Pencil.Gaming.GLFW3 is not valid, isn't it ? he was uploaded after the last commit on the offical repo. I guessed it was updated and reliable.

aloisdg avatar May 27 '15 21:05 aloisdg

I don't know... I just tried in VS2013 on a new machine and I'm getting all the same errors as you, so going to look into it all right now.

delaneyj avatar May 27 '15 21:05 delaneyj

For the migration, I used a PowerShell script by @owen2.

aloisdg avatar May 27 '15 21:05 aloisdg

I'm not at my fresh machine to test, the missing .dll/Nuget setup was not fully add (.gitignore stuff) so if you get to it before the morning (Pacific Time, USA) let me know if it works for you.

Btw for clarity for coming to the project the GLW3 build on NuGet is for 32 bit, so I built from source and hard reference. Really should make a pull request to the Pencil.Gaming repo or relook into OpenTK and see if my original concerns are still valid (mostly multi-windowing issues).

delaneyj avatar May 28 '15 04:05 delaneyj

I just finished the migration. It works well here. Do you think we should open an issue on Pencil.Gaming to ask for an official nuget package? We could make it by ourself but it will be better if an official one is maintained.

aloisdg avatar May 28 '15 23:05 aloisdg

Yes that'd be great, it doesn't seem like its being actively worked on. Either we need to create a Issue for him to update NuGet, or possible try to get OpenTK back and working. I stopped using the OpenTK version cause I wanted to support multi-window setups and it just wasn't built with that in mind. In a perfect world it'd come down to what can both support multi-window and easy cross platform integration. Actually I found the original issue and maybe it has been fixed in the last few months. Worth investigating either way.

delaneyj avatar May 29 '15 05:05 delaneyj