datastar icon indicating copy to clipboard operation
datastar copied to clipboard

Add `X-Accel-Buffering` to Python SDK

Open Laurent2916 opened this issue 8 months ago • 4 comments

to prevent nginx from buffering stuff

Laurent2916 avatar Apr 15 '25 10:04 Laurent2916

Seems like a good idea. @lllama ?

bencroker avatar Apr 15 '25 14:04 bencroker

Still waiting on a review from @lllama...

bencroker avatar Apr 29 '25 12:04 bencroker

Hmm. I think there was discussion on Discord that we'd avoid adding specific headers in the SDKs. Do we know if the other SDKs are adding this?

lllama avatar Apr 29 '25 13:04 lllama

The PHP SDK uses this as a default header, and the Ruby one too, so I think it depends on how common it is to use nginx with Python.

bencroker avatar Apr 29 '25 14:04 bencroker

Still on the fence about this one but I don't think it'll do any harm or introduce surprising behaviour, so ok to merge.

lllama avatar Jun 02 '25 13:06 lllama

Merged, thanks!

bencroker avatar Jun 02 '25 15:06 bencroker