Ben Delaney

Results 13 comments of Ben Delaney

Just pinpointed weird behaviour I have been seeing to this same issue. I keep a global table of windows that I update upon subscription events using `wf:getWindows()`. I have bound...

@darind This part of PromiseProxy seems to be be the culprit: https://github.com/NativeScript/ns-v8ios-runtime/blob/92195e8f7c02aa50a97d686757e0b04070c78ef7/NativeScript/runtime/PromiseProxy.cpp#L18-L26 Replacing with ``` let promise = new target(origFunc) ``` or commenting out the script in PromiseProxy entirely fixed...

Not exactly clear what situation it becomes useful as long as V8 locking is used properly, and I'm not sure it works fully as intended using try-catch blocks in async...

9721e19 resolves a leak which comes from the runtime handling the second arg to CFRunLoopPerformBlock, `kCFRunLoopDefaultMode`, but that's unrelated to the bulk of the unreleased allocs, which are made in...

The only noticeable memory leak triggered by [my original snippet](https://github.com/NativeScript/ns-v8ios-runtime/issues/100#issuecomment-765888341) is patched by https://github.com/NativeScript/ns-v8ios-runtime/commit/9721e195c5e591d4776f485e92ff2c7039b7d215. Unfortunately afterwards I discovered that when testing that patch on the original issue https://github.com/NativeScript/NativeScript/issues/9151, the patch...

Together with https://github.com/NativeScript/ns-v8ios-runtime/commit/9721e195c5e591d4776f485e92ff2c7039b7d215, these totally fix the memory leak for me: https://github.com/NativeScript/ns-v8ios-runtime/compare/master...delaneyb:fix-JSBlock-leak There were definitely issues with: 1. ffi_closure_free never being called for https://github.com/NativeScript/ns-v8ios-runtime/blob/d3eecf29633a130329fdf6302f86241d245cd1e4/NativeScript/runtime/Interop.mm#L61 which I have fixed up for...

> Hello @delaneyb , I confirm that your commits in relation to this issue totally fix the problem both on Simulator and on real device. > I have put the...

Nope, scratch that - been debugging with #83 in XCode for hours now with my fixes in place, way too confused to try explain what's going on but it's the...

Stabbing in the dark I've come up with this which seems to somehow prevent hanging but not exactly sure how/why. JsV8InspectorClient.mm ![image](https://user-images.githubusercontent.com/18545667/103748005-93624580-5057-11eb-89dc-056b6e6761fc.png)

facebook-login v12 introduces a transitive dependency via facebook-common on androidx.fragment 1.3.0 that breaks navigation in nested frames, as @nativescript/core and @nativescript/android expect 1.2.5 which doesn't cause the issue. Here is...