facepaste icon indicating copy to clipboard operation
facepaste copied to clipboard

URL Problems

Open joesimmons opened this issue 10 years ago • 2 comments

The script is working on urls like this https://www.facebook.com/media/set/?set=a.10152274350110058.924369.691130057&type=3

but not on urls like this (same album, different url) https://www.facebook.com/meghannicK5on/media_set?set=a.10152274350110058.924369.691130057&type=3

The problem is that, the former url is what the href is for the album link, but when you click on it, it goes to the latter url.


I fixed it for now by changing line 6 of overlay.js to this

if ( /^\/[^/]+\/media_set$|^\/media\/set\/$/.test(content.location.pathname) )

I'm sure the RegExp could be refined a little (particularly changing the [^/]+ to something more specific) but it works for now.


Here's a patched temporary version: https://www.dropbox.com/s/xklknvdc4i17ktl/facepaste-2.8-fx-fix.xpi

joesimmons avatar Aug 22 '14 04:08 joesimmons

I also wrote a version combining both your fix and also a fix for the link of photos_stream that is photos_all now, should I upload it?

b3bis avatar Sep 05 '14 06:09 b3bis

Check if #22 solves this issue. I've prepared a PR (#23) from issue #22. I'm wondering if original author would at least merge fixes and release new versions.

akostadinov avatar Jan 06 '15 11:01 akostadinov