shuppy

Results 144 comments of shuppy

> Isn't it installed [here](https://github.com/servo/ci-runners/blob/15dd43b0587865d520820779012cc108f7798c8d/profiles/servo-ubuntu2204/boot-script#L81)? I think it was added as part of [servo/ci-runners#24](https://github.com/servo/ci-runners/pull/24) it’s indeed installed now, but it’s not clear to me if that was correct in the...

oh, sorry, i see this part of the issue was incorrect because i copied and pasted from the other issues: > GitHub-hosted runners satisfy this, but our servo-ubuntu2204-wpt image currently...

this seems to be caused by rust-lang/rust#140686, which funnily enough, is the same exact bug i used this tool to find in servo/servo#36818! thanks for making this very useful tool...

i guess we’ll want a compile-time option that overrides the usual search logic with a fixed resources path?

in [servoshell](https://servo.org), we need to build AccessKit nodes for web content in the webview, and combine it with the AccessKit tree for the egui widgets in the surrounding UI. it...

so we went away and played with that, and found that while building our custom subtree in accesskit_subtree_builder() was useful, it forced us to rebuild that subtree on every pass....

``` $ git clone https://github.com/emilk/egui.git $ ( cd egui; git checkout 0.33.2 ) $ git clone https://github.com/AccessKit/accesskit.git $ ( cd accesskit; git checkout subtrees ) ```

Interesting! I hadn’t noticed because I usually run `RUST_LOG='warn,servoshell,...'`. I think `tracing` may be [emitting `log` records](https://docs.rs/tracing/0.1.40/tracing/#emitting-log-records) (note that only the “additional” records are trace level): > When the “log”...

So we could disable the `tracing/log` feature, or we could make sure every thread(?) has a tracing subscriber. I’m not sure we can do the former without patching `webdriver` *and*...

> While it appears my original comment was not 100% accurate, I'm still very much in favor of disabling the `tracing/log` feature, since I believe tracing and logging have different...