fishwife icon indicating copy to clipboard operation
fishwife copied to clipboard

Published 20 hours ago • verified publisher icon dekellum

Update for JRuby 9.2+

Open headius opened this issue 3 years ago • 1 comments

These are minimal changes to support working on JRuby 9.2 and up, which are the currently-supported JRuby versions. I was unable to run the tests due to errors building (something in the toolchain is using an http URL for Maven that no longer exists).

  • CallBlock.newCallClosure with Arity was deprecated some time ago and removed in 9.3. The Signature version works on 9.2+.
  • RuntimeHelpers is replaced with Helpers.
  • createNativeRaiseException is deprecated, so the patch converts IOException instances to their equivalent Ruby IOError subtypes.

There may be more work needed to get this fully-functional on JRuby 9.2+ but this is at least a minimum set of changes.

headius avatar Jan 18 '22 21:01 headius

Tested the changes in our vendored copy of Fishwife and it works as expected. Thank you for your help!

kovyrin avatar Jan 18 '22 22:01 kovyrin