rails_panel icon indicating copy to clipboard operation
rails_panel copied to clipboard

Published 20 hours ago • verified publisher icon dejan

Allow callers from some files to be ignored

Open mikeweaver opened this issue 7 years ago • 8 comments

mikeweaver avatar May 15 '17 05:05 mikeweaver

This is for https://github.com/dejan/rails_panel/issues/123

mikeweaver avatar May 15 '17 05:05 mikeweaver

@dejan Any chance I can get this into the mainline?

mikeweaver avatar May 18 '17 22:05 mikeweaver

Due to recent changes this PR is no longer valid. @mikeweaver are you interested in fixing it?

gogiel avatar Jul 04 '19 21:07 gogiel

Yes, I'm interested in fixing it...if it gets merged to the mainline this time around. Two years gathering dust taxes one's motivation. :-)

mikeweaver avatar Jul 06 '19 20:07 mikeweaver

Great to hear from you :) I have a collaborator status. Once you update the PR I'll be able to review and merge to master.

However I can't guarantee the due date for a new gem version release as it's beyond my capabilities.

Thanks.

gogiel avatar Jul 06 '19 21:07 gogiel

@gogiel I rebased my changes onto the latest master and have a green build. Should be good to merge. LMK if I missed something.

mikeweaver avatar Jul 19 '19 03:07 mikeweaver

@gogiel i can get this gem released once it's merged, just ping me.

modosc avatar Jul 21 '19 19:07 modosc

@mikeweaver thanks! I see that you're introducing new concept of config YAML files. How about using currently existing solution of configuration block?

I believe that configuration in Ruby code is more flexible and simple. We can add YAML config too but it should be consistent with all existing config options.

Please rebase master again. I reverted accidentally removed code in Config, https://github.com/dejan/rails_panel/pull/160

gogiel avatar Jul 23 '19 19:07 gogiel