Avi Deitcher
Avi Deitcher
Oh yeah, and remove from "draft"
One of the commits isn't signed. Either sign that one, too, or squash them to a single signed commit, please.
The DCO still is failing. Please check how to pass it [here](https://github.com/linuxkit/linuxkit/pull/4103/checks?check_run_id=36808377039)
Looks good to me. We don't actually exercise it as part of CI (the tests there mostly use UEFI), so please confirm that you did a build and booted it...
Tests are failing because `tools/` packages are not pushed automatically by CI. I can handle that and restart the failing tests.
Pushed out, restarted failing tests. Let's see if CI is clean.
Getting failure [here](https://github.com/linuxkit/linuxkit/actions/runs/13194631473/job/36842149722?pr=4103#step:11:193). Did you forget to copy over some dependencies?
Yes I think that makes sense. The current method was `apk add syslinux`, which included all dependencies. By doing it in an earlier stage and just copying over the files...
> never restarted True. This probably could be supported with [containerd's restart extension](https://pkg.go.dev/github.com/containerd/containerd/runtime/restart). Although I have not used it. Would be more than happy to accept a PR with it.
> I guess this just needs to be plumbed into the config and do the correct thing Pretty much. There is nothing inherent in the structure that says we cannot...