example-bundles icon indicating copy to clipboard operation
example-bundles copied to clipboard

WIP: add duffle.json files for each example

Open bacongobbler opened this issue 6 years ago • 6 comments

This allows users to build their bundles from source.

Signed-off-by: Matthew Fisher [email protected]

bacongobbler avatar Nov 29 '18 21:11 bacongobbler

Do we have a "deislabs" canonical email address, or somewhere we can point users to? I used @technosophos's email as a placeholder.

bacongobbler avatar Nov 29 '18 21:11 bacongobbler

There's probably two or three examples that currently don't translate well into duffle build, which off the top of my head are hellohelm and compose. Both issues are being tracked at deislabs/duffle#546 and deislabs/duffle#547

bacongobbler avatar Nov 29 '18 22:11 bacongobbler

I was curious why/how CI (https://github.com/deislabs/bundles/pull/55/checks) was happy since the tests/validation currently hinge off of the bundle.json file in each bundle repo. Sure enough, it doesn't complain b/c we only run if said file exists. As it looks like most/all bundle.json files are being removed (or replaced), we'll need to update logic here to parse/use duffle.json instead -- holler at me if I can help!

Though, in addition, I have one higher-level question/thought. With this change we are definitely moving toward this repo as being "duffle's CNAB bundle" store -- I guess this repo isn't meant to be more of a generic CNAB bundle showcase (not tied to any particular implementation, in this case duffle)?

vdice avatar Nov 29 '18 23:11 vdice

I guess this repo isn't meant to be more of a generic CNAB bundle showcase (not tied to any particular implementation, in this case duffle)?

Oh! I was not aware that this was meant to be a generic CNAB bundle runtime showcase. In that case this PR is completely irrelevant and should probably be closed instead.

Oh well, at least it allowed me to find a few bugs in duffle build trying to re-create these CNAB bundles :)

bacongobbler avatar Nov 30 '18 18:11 bacongobbler

Oh, I was intending that to be more of a question/opening up for discussion. I don't know if we'd ever really talked about the future intended for this repo... I was just working on assumptions, which we all know how that ends :)

Thoughts on this @technosophos ? Have this repo continue to be more of a generic CNAB bundle showcase or bring more of duffle into the mix?

vdice avatar Nov 30 '18 18:11 vdice

Sorry, I'm afraid I may have introduced confusion here.

  • The primary reason for this repo is to show examples of CNAB bundles
  • Having duffle.json files is totally fine, though, as long as we're also checking in the bundle.json files.
  • If we add the duffle.json files, we'd better update the make file to make sure we produce the bundle.json files

Again, the rationale behind this repo is that we send people from the spec to this repo to see how CNAB works.

technosophos avatar Nov 30 '18 19:11 technosophos