bindle icon indicating copy to clipboard operation
bindle copied to clipboard

invoice object returns a Vec<Parcel> as type "parcel"

Open bacongobbler opened this issue 2 years ago • 3 comments

Should these fields be made plural to match other fields?

https://github.com/deislabs/bindle/blob/9487388a7e306c10a9c71bd6adac1aafde1678be/src/invoice/mod.rs#L79-L81

IMO we should be listing these as "parcels", "groups", and "signatures" as we're dealing with a list of objects rather than a single object.

That being said, this would break backwards compatibility with older bindle clients.

I noticed this while updating bindle-dotnet to the newest bindle APIs.

bacongobbler avatar Apr 27 '22 16:04 bacongobbler

We had it that way originally but changed our minds for a specific reason I can't remember. @technosophos do you remember?

thomastaylor312 avatar Apr 27 '22 19:04 thomastaylor312

#34

itowlson avatar Apr 27 '22 20:04 itowlson

Yeah that is where we changed it, but we had an "in person" discussion about why we were doing it

thomastaylor312 avatar Apr 29 '22 20:04 thomastaylor312