router icon indicating copy to clipboard operation
router copied to clipboard
verified publisher icon deis

fix(nginx) wait for nginx reload to avoid zombies

Open felixbuenemann opened this issue 8 years ago • 3 comments

If a unix process is spawned, the parent process must wait for its pid or the process will become a zombie after exit. This fixes the problem that the /opt/router/sbin/router binary leaves behing a defunct nginx process each time the config is reloaded by spawning "nginx -s reload".

Fixes #331.

felixbuenemann avatar Dec 13 '17 15:12 felixbuenemann

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-admin avatar Dec 13 '17 15:12 deis-admin

@felixbuenemann to the best of my knowledge, no one is actively maintaining the old components of Deis Workflow anymore.

krancour avatar Dec 14 '17 02:12 krancour

Hi @felixbuenemann and @krancour . I am from the Fork of Deis Workflow team - Hephy. https://github.com/teamhephy/

This is a good PR and we actually encountered a problem with this yesterday. Please can you make this PR against hephy-router repository and we can merge it in and get it into the first release.

Here is repository for the hephy-router: https://github.com/teamhephy/router

Cryptophobia avatar Jan 26 '18 15:01 Cryptophobia