cpupower icon indicating copy to clipboard operation
cpupower copied to clipboard

Make default profile names translateable

Open fin-ger opened this issue 2 years ago • 2 comments

As suggested by @MarekPikula in #160.

There are two separate approaches for this:

  1. Translate profile names only when no profiles exist yet, which would be most likely during the first launch of the extension on a system
  2. ~~Translate all 4 default profiles regardless of whether the profiles existed before or not~~

Pros for 1:

  • ~~Existing profile names stay as they are, so users won't be confused~~
  • Existing profiles may optionally be translated in an update dialog otherwise profile names stay as is (as pointed out in https://github.com/martin31821/cpupower/issues/164#issuecomment-930220158)

Cons for 1:

  • ~~All existing users won't benefit from this feature~~
  • None

~~Pros for 2:~~

  • ~~All existing users would benefit from the new translation~~

~~Cons for 2:~~

  • ~~E.g. a german user might enter "High Performance" which would be automatically translated to "Hochleistung" although that was not the intention~~

Alternatives

Instead of translating the default profile names, we could leave it as is and let the users translate the profile names on their own.

fin-ger avatar Sep 29 '21 14:09 fin-ger

Or you could add it as an option during update process, so the user would be well aware that it's happening and could choose to opt out. I presume it would be much more work, but IMHO it would provide the best UX.

MarekPikula avatar Sep 29 '21 14:09 MarekPikula

Oh right, this is I think the way to go

fin-ger avatar Sep 29 '21 14:09 fin-ger