Andreas Deininger

Results 65 comments of Andreas Deininger

> I still have hope that this will get merged one day. 🥇 Me too. I realize that this PR pulls in tocbot.min.js from `static` folder. Since tocbot is actively...

> So this change is unnecessary then, right @deining? Yes, correct. > If so, let's close it. Done.

Shortcode `card-code` was deprecated meanwhile; use shortcode `card` with named parameter `code=true` instead. With `card`, you will have footer support :smile: This ticket is not applicable any more and can...

> I'll continue to explore if/how this shortcode can further be simplified -- ideally, so that we can avoid the use of the `markdownify` shortcode argument I rebased your PR...

> I'd suggest getting rid of the h4 heading, and replacing it with a non-heading styling. Great suggestion, done. @fekete-robert: can you comment on/review this PR?

> Thanks for the updates @deining. I've revisited this PR, making the following adjustments: > > * Recovered the `.h4` _styling_ of the alert header, without making it heading element...

Rebased PR and fixed code style issues. IMHO this PR is eventually ready for merging.

I move breaking change note to the correct section in the `CHANGELOG`. With two approving reviews given, any reason to not include this in the upcoming 0.10.0 release?

> > I move breaking change note to the correct section in the `CHANGELOG`. > > Thanks. You are welcome. > > With two approving reviews given, any reason to...

Any chance to get this PR merged eventually? I would love to see this contribution landed.