Lines not smooth

[kidvicious]

Curved lines appear angular..Can you make it smooth?

[dehli]

Hi @kidvicious, thanks for the comment. Can you explain what you mean? From the README's image they don't look angular to me. Is that not what you're seeing? Can you show an example? Thanks!

[kidvicious]

i mean the curves are not rounded like here. Can it not be a perfect curve because this is what I require in my app.

[dehli]

Gotcha. Thanks for the post! When I get time I will investigate this, however if you figure out a way to fix it I welcome PRs :)

[Parameshvadivel]

@dehli Hey, have you cleared curve issue. Can you please update it soon. It will be more helpful..

[dehli]

I haven't yet. Like I said, I will investigate this when I have time. Feel free to open a PR if you fix it though. Cheers!

[dehli]

I started investigating this last night. Should have a solution shortly :)

[Parameshvadivel]

Thanks for reply.. Can you make it little bit fast. Pls..

[dehli]

I pushed up a solution to issue/#19-smooth-lines. If you want to test out the new branch, you can update your CocoaPods so it looks like:

pod 'TouchDraw', :git => 'https://github.com/dehli/TouchDraw.git', :branch => 'issue/#19-smooth-lines'

Let me know how it works for you.

[Parameshvadivel]

Thanks updates.. https://drive.google.com/file/d/1APE2l-nSCIDIr5tHKkp5s2hh7_7RJuZ0/view?usp=sharing Still line curve are breaking.. can you use context?.addQuadCurve(to: <#T##CGPoint#>, control: <#T##CGPoint#>) instead of context!.addLine(to: CGPoint(x: toPoint.x, y: toPoint.y))

addQuadCurve brings smooth curve can check it out that pls...

[Parameshvadivel]

@dehli Any updates bro...

[dehli]

Hi @Parameshvadivel, I haven't been able to work on it any more since yesterday. Feel free to submit a pull request with your solution if you've tested that it works and I'll review it. When there are any updates, I will post them here though. Cheers.

[Parameshvadivel]

ok sure. thanks!!

---

Sincerely, Parameswaran V

“It is hard to fail, but it is worse never to have tried to succeed.” ― Theodore Roosevelt

---

From: c.p. [email protected] Sent: 19 April 2018 18:54:05 To: dehli/TouchDraw Cc: Parameswaran Vadivel; Mention Subject: Re: [dehli/TouchDraw] Lines not smooth (#29)

Hi @Parameshvadivelhttps://github.com/Parameshvadivel, I haven't been able to work on it any more since yesterday. Feel free to submit a pull request with your solution if you've tested that it works and I'll review it. When there are any updates, I will post them here though. Cheers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dehli/TouchDraw/issues/29#issuecomment-382733557, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVaFxyc2CP0mZ4N8IjLvo-jh2DfZq6HTks5tqI_1gaJpZM4TCyhf.

[matthiasnagel]

Looks good. Will this be merged to master and released?

[dehli]

Hi @matthiasnagel, if you notice improvements with it I will go ahead and merge it! I was under the impression that it didn't help. Thanks for the feedback!

[X901]

I just noticed it today when I was following this article
https://medium.com/@rajejones/add-a-signature-to-pdf-using-pdfkit-with-swift-7f13f7faad3e

did you fixed it ?

[dehli]

Hey @X901, thanks for reaching out! What did you notice today?

[X901]

The cerves is not smooth See this picture https://cl.ly/a47f9457442c

[X901]

Before and after using the smooth-lines branch

I didn't notice any different

The same issue the lines doesn't smooth

[dehli]

Thanks @X901! I haven't had time to address this but it's on my radar. Definitely open to PRs though if you come up with a solution!