Sam DeHaan
Sam DeHaan
I updated to fix the location of the changelog, will merge once CI passes. Thanks for the contribution!
Pinging for codeowner review. @mrsillydog @Caleb-Hurshman . Looks good to me, will put an approval stamp on after CI passes.
@NN--- I believe this is still waiting on addressing the feedback above from @\atoulme > Please clarify in the README that the filters are a union, meaning all application names...
While this says it can merge automatically, it looks like the changelog may be merged incorrectly. Can you merge main/rebase to ensure the changelog entry goes into the unreleased section?
> Hi @dehaansa, just checking in — have there been any updates on this PR? Let me know if there's anything I can do to help move it forward. Happy...
> @dehaansa does disallowing scheme make sense to you since we are only using TCP to inspect the certificate? I would personally lean towards accepting scheme, and provide a meaningful...
> > > @dehaansa does disallowing scheme make sense to you since we are only using TCP to inspect the certificate? > > > > > > I would personally...
My expectation would be that an http scheme would cause an error during startup/config validation, stating that any URLs provided to the receiver must use an https scheme. These are...
CC @bogdandrutu as you appear to have done recent work on the scraper packages
I put together a POC [here](https://github.com/open-telemetry/opentelemetry-collector/pull/13167) if anyone would like to review an implementation of 2 with serialized as default, going to evaluate in contrib tomorrow.