nova-filters-summary icon indicating copy to clipboard operation
nova-filters-summary copied to clipboard

Empty date filters detected as active

Open dm-pf opened this issue 3 years ago • 4 comments

Hi, awesome stuff! Thanks!

We have some filterable date fields around:

Date::make('Version Date', 'version_date')
    ->filterable()
    ->sortable()
    ->onlyOnIndex(),
Date::make('Created at', 'dob')
    ->filterable()
    ->sortable(),

And without setting any filters, the package thinks these filters are populated and displays empty like this: image

PS: In my Nova install, I didn't have the pl-2 class so I had to add it myself.

dm-pf avatar Dec 08 '22 15:12 dm-pf

+1

rafaelsmith avatar Dec 09 '22 11:12 rafaelsmith

Created PR to fix the bug https://github.com/degecko/nova-filters-summary/pull/7

@degecko @dm-pf

ali-raza-saleem avatar Jan 04 '23 22:01 ali-raza-saleem

How about that PR?

I have the same problem on the Number field.

wamesro avatar Feb 02 '23 15:02 wamesro

@rafaelsmith @the-alichemist @wamesro

I have forked the repository applying the fix by @the-alichemist and adding some more extra fixes that were needed.

Feel free to use that repository for the time being.

dm-pf avatar Mar 17 '23 12:03 dm-pf