re-frame-firebase icon indicating copy to clipboard operation
re-frame-firebase copied to clipboard

Firebase transaction

Open benzenwen opened this issue 5 years ago • 3 comments

Firebase's transaction provides for atomic data modification, useful for multi-user applications that edit data dynamically.

This pull requests implements a straight JavaScript translation :firebase/transaction, and a more Clojure-y variant :firebase/swap that accepts an :argv vector for passing in other values.

Please let me know if there are any suggested changes or administrative tasks that I can undertake that make your review easier.

Thank you for your consideration.

benzenwen avatar May 21 '19 10:05 benzenwen

Rebased to a single commit as discussed.

With gratitude, B.

benzenwen avatar Jun 27 '19 08:06 benzenwen

I just read your comments and skimmed the code. I like this direction a lot; thanks for writing it!

My only problem is that I don't have time to test for at least the next week or two. For now, please continue using this privately, with my assurances that:

  • I expect that I will happily accept this code sometime soon
  • I don't plan to make any other changes to master before this code

If other folks are reading this exchange and also wants to use this, please upvote or comment.

deg avatar Jun 28 '19 12:06 deg

Thank you. 🙏 That timing is fine. Let me know if there are any changes you'd recommend.

benzenwen avatar Jun 29 '19 06:06 benzenwen