yescrypt icon indicating copy to clipboard operation
yescrypt copied to clipboard

Increase Testing Range

Open defuse opened this issue 10 years ago • 2 comments

Solar Says:

OK. However, I'd like the testing to include at least r=8, so perhaps you can be testing wider ranges for each one of these parameters, just not for all at once? E.g. there should be no problem testing r=8 when t=0, if you're able to test r=4 with t=4. Perhaps introduce an extra testing phase, which would test those wider ranges non-exhaustively wrt the remaining parameters? And keep the exhaustive testing for the smaller values as you have described above (or you can reduce it to e.g. N <= 12 to free up some running time for the extra phase).

defuse avatar Jun 22 '15 05:06 defuse

I added a custom_cases array to the test code, so we can easily add cases manually. I added cases for r=8, r=16, and for empty passphrase and salts.

Next, evaluate whether we have good enough coverage. Add test cases where we are missing some, and then this ticket can be closed.

defuse avatar Jun 23 '15 02:06 defuse

Make sure everything in TESTS-OK and PHC-TESTS-OK is covered (except for the encoding, obviously), and then this ticket can be closed.

defuse avatar Aug 16 '15 21:08 defuse