php-encryption icon indicating copy to clipboard operation
php-encryption copied to clipboard

"decryptResourceInternal" method visibility public

Open kronthto opened this issue 1 year ago • 1 comments

I was wondering, why is this public/exposed, all the other "Internal" methods appear to be private. I couldn't find external references to it. Just an oversight?

https://github.com/defuse/php-encryption/blob/90060874f868d0711890e67456b4f26930fc478f/src/File.php#L457

It's not a big problem though, and changing this risks breaking integrations in the wild that are using it directly now.

kronthto avatar Apr 19 '23 10:04 kronthto

Good point, it indeed should have been private. Thanks!

defuse avatar Apr 20 '23 16:04 defuse