php-encryption icon indicating copy to clipboard operation
php-encryption copied to clipboard

Modernize the PHP-CS-Fixer rules

Open NicolasCARPi opened this issue 5 years ago • 2 comments

  • Require PHP-CS-Fixer as dev dependency
  • Modify .gitignore to ignore php_cs.cache and generated coverage files
  • Run the "fix" command on the codebase

NicolasCARPi avatar Jun 02 '19 19:06 NicolasCARPi

Note that the tests are failing with travis for an unrelated reason.

NicolasCARPi avatar Jun 02 '19 19:06 NicolasCARPi

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (13fe6f8) to head (933e9dc). Report is 100 commits behind head on master.

Files with missing lines Patch % Lines
src/Core.php 75.00% 1 Missing :warning:
src/KeyProtectedByPassword.php 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files           9        9           
  Lines         925      925           
=======================================
  Hits          830      830           
  Misses         95       95           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '19 21:10 codecov[bot]