Taylor Hornby

Results 188 comments of Taylor Hornby

Yeah, that's an error. It used to be hex encoded and I forgot to change the parameter name.

This is blocking adoption: https://github.com/Webiny/Framework/issues/39#issuecomment-80982903

It definitely shouldn't require PHP 7. It falls back to using `mcrypt_create_iv` if `random_bytes` isn't available. See the code here: https://github.com/defuse/password-hashing/blob/master/PasswordStorage.php#L36-L48 If both `random_bytes` and `mcrypt_create_iv` are unavailable then you...

@Torniojaws: Is it still broken for you?

Glad you got it working! That shouldn't have been necessary. Perhaps `mcrypt_create_iv` is missing and _that_ was failing silently. I'll leave this ticket open for us to test what happens...

Good idea! I'll do it when I get some free time, which might mean in a really really long time. (Note to future self: If this ticket is still open...

Dear past self, I am currently busy being a grad student. Dear future self in 2018, Please revisit this issue, now that IPv6 is hopefully more used than IPv4.

Dear past self, I am still busy being a grad student. Why didn't you start writing your thesis sooner!?

Dear past self, IPv6 adoption has been disappointing at best. It was a good call to work on more important things. Hmm this might be interesting to revisit soon. It...

Does this thing even still work as a DoS attack (on IPv4)? I haven't actually tried it in years.