github-gem icon indicating copy to clipboard operation
github-gem copied to clipboard

New version with a host of patches from various forks included - now supports ruby 1.9

Open kristianmandrup opened this issue 15 years ago • 2 comments

Check it out at: http://github.com/kristianmandrup/github-gem

kristianmandrup avatar Jun 17 '10 07:06 kristianmandrup

I am so scared to attempt to merge this in; but very keen.

Is the 0.4.6 history summary the sum total of all the patches?

+== 0.4.6 2010-30-11
+Fixed Shell bug using fork from 'bronson'
+  replace @error = err if err.any?
+  replace @out = out if err.any?
+
+Refactored into:
+  replace @error = err unless err.empty?
+  replace @out = out unless out.empty?
+
+Also added String extension just in case bug is elsewhere...
+
+class String 
+  def any?
+    !empty?
+  end
+end

drnic avatar Jan 31 '11 00:01 drnic

Arhh, pooey, you have merged in stuff I just merged in. Damn.

Do you have time to check whether your branch matches with the current HEAD?

Grab me on skype at nicwilliams if you want to talk too.

drnic avatar Jan 31 '11 00:01 drnic