{ hash: true, empty: true } yields empty values for `name[]` (no index)

[nhunzaker]

I'm working on an app with the following inputs:

<input type="checkbox" name="types[]" value="activities" checked />
<input type="checkbox" name="types[]" value="games" />
<input type="checkbox" name="types[]" value="apps" />
<input type="checkbox" name="types[]" value="videos" checked />

I'm using { hash: true, empty: true } so that I can serialize down an empty types field. However the inputs that aren't checked are showing up in the serialized parameters like:

{
    "types": ["", "activities", "", "videos" ]
}

I would like:

{
    "types": ["activities", "videos" ]
}

and the following when no inputs are checked:

{
    "types": []
}

What do you think about stripping out unchecked boxes if the name field includes no index?

[defunctzombie]

Seems pretty reasonable if right now it just returns empty strings for those fields. What is the equivalent form-encoding string for the above input (i.e. when hash: false is used)

[nhunzaker]

A quick test shows that it only includes the checked values, using:

<form action="/" method="POST">
  <input type="checkbox" name="types[]" value="activities" checked />
  <input type="checkbox" name="types[]" value="games" />
  <input type="checkbox" name="types[]" value="apps" />
  <input type="checkbox" name="types[]" value="videos" checked />
  <button type="submit">Go</button>
</form>

If I inspect the networking tab, only the checked inputs are included:

I'll jam on this a bit and send out a PR.