dom-events icon indicating copy to clipboard operation
dom-events copied to clipboard

Published 20 hours ago • verified publisher icon defunctzombie

consider integrating fix-ev

Open juliangruber opened this issue 12 years ago • 5 comments

https://github.com/juliangruber/fix-ev

for older browsers

juliangruber avatar Jun 26 '13 11:06 juliangruber

if you want this in i'll make a pull request

juliangruber avatar Jun 26 '13 11:06 juliangruber

Yes please. I would like to see a PR for it to get an idea of what that would look like.

Tests included would be :heart:

defunctzombie avatar Jun 26 '13 11:06 defunctzombie

Would you still be interested in a PR for this?

callumacrae avatar Mar 24 '15 10:03 callumacrae

Couldn't hurt. I personally don't have use case for old IE but if you do I would entertain the PR.

defunctzombie avatar Mar 24 '15 16:03 defunctzombie

I do :cry:

I'm not actually using your library, because I'm only interested in .on. Adding fix-ev to your library isn't trivial—if you want .off to work correctly in oldIE still, you have to store every listener in an array and remove the correct one.

If I need to use more than .on, I'll use this library and add this functionality :smile:

callumacrae avatar Mar 24 '15 16:03 callumacrae