telegraph icon indicating copy to clipboard operation
telegraph copied to clipboard

private to protected in WebhookHandler

Open BeyCoder opened this issue 2 years ago • 6 comments

Hi, I need to override handleCallbackQuery, but it's a private function. It's impossible to create your own handling of callbackQuery.

I think, here should be protected instead of private

BeyCoder avatar May 16 '23 22:05 BeyCoder

Hi, may I ask why do you need to override handleCallbackQuery?

fabio-ivona avatar May 18 '23 13:05 fabio-ivona

Hi, may I ask why do you need to override handleCallbackQuery?

Hi. Sure, I have created a plugin system, so, callbackQuery is executing in another class.

Here is an example with a command executing: image

P.S. Also it's possible to create something like handleUnknownCallbackQuery. Maybe it will be better than changing the accessor.

BeyCoder avatar May 18 '23 18:05 BeyCoder

I got your point, will implement a way to handle unknown callback queries soon ;-)

fabio-ivona avatar May 18 '23 20:05 fabio-ivona

I got your point, will implement a way to handle unknown callback queries soon ;-)

I can implement and send PR if my help is needed :3

BeyCoder avatar May 18 '23 20:05 BeyCoder

Sure! Any help is welcome ❤️ feel free to open a PR

fabio-ivona avatar May 18 '23 20:05 fabio-ivona

It was released in 1.53.0 version

andrey-helldar avatar Oct 02 '24 18:10 andrey-helldar

@fabio-ivona can you close this issue?

andrey-helldar avatar Jan 27 '25 10:01 andrey-helldar