defenseunicorns
Fix repository.go
fix: Clone of Azure devops git repo not working with private repositories
Refs: #2994
Description
Added return in case the Repository is correctly cloned by gitCloneFallback
Related Issue
Fixes #2994
Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [ ] Contributor Guide Steps followed
Deploy Preview for zarf-docs canceled.
| Name | Link |
|---|---|
| Latest commit | 5c08c82061dead4bbb49a2d638f824b70199b197 |
| Latest deploy log | https://app.netlify.com/projects/zarf-docs/deploys/6888f67e495cf00008c52636 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
:x: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/internal/git/repository.go | 0.00% | 1 Missing :warning: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/internal/git/repository.go | 17.24% <0.00%> (-0.09%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ittacco Hey looks like something went wrong when you did DCO, it's currently showing 240 files changed. Could you reset this PR, I know it was originally a couple line change. If you git reset main then re add your changes, sign your commit and force push it should work.
Hey @ittacco ! appreciate the contribution here and would love to help you get this merged if you are still interested in working on it.
@brandtkeller any change to get this merged? seems to be blocking the usage of azure devops repos
@joaofasilva-kitar I agree - let's get this over the line.
@ittacco I believe it looks good - I don't want to update your branch/fork for you in the event there is still future work to do. So if you can get this branch up-to-date we can get it tested and over the finish line!
Hi everyone! Any updates on getting this merged/deployed? Thanks and have a great vacation period!
This change in isolation appears to result in some failing tests - @joaocc I will see if I can find some cycles to look at the results of testing and identify a path forward.
Incorporated the intent of this change plus some enhancements into #4186 - which as subsequently been merged.
CC: @joaocc @joaofasilva-kitar