zarf icon indicating copy to clipboard operation
zarf copied to clipboard

Several functions in Zarf need to be more context aware and return an error after context is cancelled

Open AustinAbro321 opened this issue 8 months ago • 0 comments

With the recent change in #2567 which changed Zarf to cancel context instead of running os.exit(1) after the first SIGINT, we need to change functions to use context and return an err up all the way up the stack when context is cancelled.

Note: A second sigint will always `os.exit(1)

The following is a list of functionality that needs context, but there are likely several more:

  • [ ] File downloads on create
  • [ ] During data injections on deploy
  • [ ] Image pull on create - this cannot be properly fixed until we switch from using crane, perhaps to ORAS which implements context, or crane implements context
  • [ ] helm install / upgrade

AustinAbro321 avatar Jun 20 '24 18:06 AustinAbro321