zarf
zarf copied to clipboard
feature: new wait for resource command that uses kstatus
Description
This change adds a new wait-for-resource
command which is meant to replace the original wait-for
command in the future. The main difference with the new command is that it uses kstatus to determine the readiness of a resource rather than requiring users to specify a condition. This functionality is implemented using a library rather than shelling out to kubectl. The goal is to in a later PR replace the Zarf wait shorthand to use this code instead of shelling out to the tool.
Related Issue
Relates to #2203
Checklist before merging
- [ ] Test, docs, adr added or updated as needed
- [x] Contributor Guide Steps followed
Deploy Preview for zarf-docs ready!
Name | Link |
---|---|
Latest commit | 6000d23ca318f704e5ae1deca669e98e90829af5 |
Latest deploy log | https://app.netlify.com/sites/zarf-docs/deploys/6644d4b8334c7700083ad9c9 |
Deploy Preview | https://deploy-preview-2497--zarf-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I had a look at this PR again as I need the wait functionality for another feature in Zarf. My question is if this is enough for it's own package. I realize that other projects also need this functionality. Would it not be better to document how to use kstatus instead? Most of the code do use kstatus is for the most part to get the required config objects.
I am closing this in favor of adding this as a feature in the package spec instead.