zarf icon indicating copy to clipboard operation
zarf copied to clipboard

fix: adopt namespace metadata

Open AustinAbro321 opened this issue 9 months ago • 2 comments

Description

Changes behavior to keep existing metadata on namespaces rather than steamrolling them

Related Issue

Fixes #2489

Checklist before merging

AustinAbro321 avatar May 10 '24 19:05 AustinAbro321

Deploy Preview for zarf-docs canceled.

Name Link
Latest commit 86549e04f71cd5a0ed847e3ed327cc8c77fd9460
Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66479b432707d100086c2f6a

netlify[bot] avatar May 10 '24 19:05 netlify[bot]

We could use client set directly instead

I'm 50/50 on this. On one hand it's simpler, on the other hand I don't mind abstracting the calls away to a separate library (like cluster since we're going to merge k8s into it). It was nice when context was implemented for example since it was a common way to change all of our k8s calls in the same package. Gonna call it direct for now, and we'll see if anyone disagrees.

AustinAbro321 avatar May 15 '24 19:05 AustinAbro321