zarf icon indicating copy to clipboard operation
zarf copied to clipboard

feat: flux OCI support in Zarf Agent

Open cmwylie19 opened this issue 1 year ago • 4 comments

Description

This features add support for Zarf to delivery Flux's OCIRepo, and HelmRepo that references an OCI URL.

Related Issue

Fixes #1974

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Other (security config, docs update, etc)

Checklist before merging

cmwylie19 avatar Sep 04 '23 12:09 cmwylie19

Deploy Preview for zarf-docs canceled.

Name Link
Latest commit 2b08e4ac959fed92c20a441fe01e2628d20c098c
Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/667eb1debec2a70008f3de3b

netlify[bot] avatar Sep 04 '23 12:09 netlify[bot]

can it also have support for ArgoCD?

gadido30 avatar Sep 15 '23 03:09 gadido30

can it also have support for ArgoCD?

There is already support for Argo https://github.com/defenseunicorns/zarf/tree/main/examples/argocd

cmwylie19 avatar Sep 26 '23 22:09 cmwylie19

This is still blocked on the flux side as trying to connect to the internal registry for login is still going over https when repo.spec.insecure is set to true.

We have created a PR on the flux side and are awaiting a response from them https://github.com/fluxcd/source-controller/pull/1412

AustinAbro321 avatar Mar 25 '24 15:03 AustinAbro321

Codecov Report

Attention: Patch coverage is 67.50000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 18.96%. Comparing base (7b8cc2d) to head (2b08e4a).

Files Patch % Lines
src/pkg/cluster/secrets.go 36.00% 15 Missing and 1 partial :warning:
src/internal/agent/hooks/flux-helmrepo.go 79.59% 5 Missing and 5 partials :warning:
src/internal/agent/hooks/flux-ocirepo.go 84.37% 5 Missing and 5 partials :warning:
src/internal/agent/http/server.go 0.00% 9 Missing :warning:
src/pkg/cluster/tunnel.go 55.55% 4 Missing :warning:
src/internal/packager/helm/post-render.go 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
+ Coverage   18.34%   18.96%   +0.61%     
==========================================
  Files         168      170       +2     
  Lines       12065    12204     +139     
==========================================
+ Hits         2213     2314     +101     
- Misses       9595     9622      +27     
- Partials      257      268      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 21 '24 14:06 codecov[bot]