pepr
pepr copied to clipboard
IB Log issue (copied from IB GitLab)
Summary
Currently when using the IB image the first log line outputs the version as v0.0.0-development. I would expect this to be 0.31.1 (or equivalent depending on version).
Steps to reproduce
-
npx pepr init
a new module -
npx pepr build --custom-image registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller:v0.31.1
-
kubectl apply
the generated manifest (you may need to handle ImagePullSecrets somehow, I usedk3d image import
to just load the image in cluster) - View pepr pod logs.
What is the current bug behavior?
Version outputs as v0.0.0-development.
What is the expected correct behavior?
Version should output as v0.31.1 (maybe with appended ironbank?).
Possible fixes
Comparing the Ironbank build and upstream build I noticed 2 differences related to version:
- https://github.com/defenseunicorns/pepr/blob/main/.github/workflows/release.yml#L47 - upstream runs
npm --no-git-tag-version version
- https://github.com/defenseunicorns/pepr/blob/main/.github/workflows/release.yml#L50 -
--build-arg VER=${{ github.ref_name }}
I believe the problem is the missing npm version
command.
Tasks
- [ ] Bug has been identified and corrected within the container
Please read the Iron Bank Documentation for more info