pepr icon indicating copy to clipboard operation
pepr copied to clipboard

Generated zarf.yaml reference helm chart rather than manifest

Open mjnagel opened this issue 1 month ago • 1 comments

Is your feature request related to a problem? Please describe.

The current npx pepr build generates a helm chart + a manifest (from the templated chart?) for deployment of pepr. The zarf.yaml that is also generated references that manifest. This limits a lot of possible end user config options (labels, resources, affinity, etc). While an end user could make a new zarf.yaml or modify the generated one, it seems preferable that the default would be to use the chart.

Describe the solution you'd like

When I npx pepr build, the zarf.yaml that is generated uses the helm chart. This allows me to import this zarf.yaml other locations and extend with values files.

Describe alternatives you've considered

As mentioned this could be done with a new zarf.yaml referencing the chart.

Additional context

uds-cli heavily leans into helm charts for overriding values in a bundle. This does provide a way that someone could modify certain pepr pieces (for good or bad) so it may require some careful consideration on whether all existing items should still be exposed as helm values.

As an aside, this would also make things like "flavored pepr" closer aligned to the approach we take in uds-core with other flavored items, using values to override the image rather than the build flag.

mjnagel avatar May 22 '24 23:05 mjnagel