Dennis Felsing

Results 489 comments of Dennis Felsing

My plan is to get this merged next week and then immediately cut a new release with it so we have some time for 128 player clients before we switch...

@fokkonaut Are you still planning to fix this or should someone else take a look? (Any volunteers? I wish I could, but I'm finding it difficult to find time) I...

Can we get this merged for 19.0?

> Can you address the comment about debug dummies, i.e. remove special handling for them from this PR, rebase on master and squash? Done

> From a release stability point of view, it doesn't make sense to start merging huge pull requests right before the release. I suggest postponing the 19.0 release by more...

> Could the clientside part of this PR be merged now? That way, once it's fully ready, it won't require a major version update e.g. 20.0. It's only bumping `MAX_CLIENTS`...

Because then you can accidentally set the server to have 128 players and you have no handling for clients which only support 64 players. So we'd have to gate all...

> That could have been the case before as well, since /whisper works with names. Right now it's highly unlikely someone will join at the same time map is reloading,...

This is now blocked by https://github.com/MaterializeInc/database-issues/issues/7452, panics reliably.

This is now part of https://github.com/MaterializeInc/materialize/pull/26291, so can be closed when that merges.