Dennis Felsing comments

Results 490 comments of


                                            Dennis Felsing

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

> Generally we do not write all bytes. I reuse some shaders e.g. for textured and non-textured vertices, even if that is theoretically less efficient. That simply makes graphics_threaded.cpp not...

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

> `https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7316` The version I use on Arch (Vulkan SDK 1.3.275, https://archlinux.org/packages/extra/x86_64/vulkan-validation-layers/): https://github.com/KhronosGroup/Vulkan-ValidationLayers/commits/vulkan-sdk-1.3.275.0/ does not contain the fix for this issue: `https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7323`

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

But what we are doing with DDNet seems so basic, we are showing 2d triangles, putting a texture on them and moving them around. If this is broken in common...

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

It's broken with MoltenVK too btw, not just AMD drivers. ![Screenshot 2024-08-06 at 23 55 50](https://github.com/user-attachments/assets/64d3e0a6-7982-4501-91d3-29d911beab0d) These places look fine: Main menu, Appearance settings, Sound settings, News

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

New revelation, it seems like everything is rendered, just in the wrong order! See how the mouse pointer appears in some places: https://github.com/user-attachments/assets/0cb19f29-1169-4b61-b176-49b0985bf783

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

> I think there aren't even so many reports of problems. I have responded to ~ 50 personally. I would guess less than 1% ask when they have such problems,...

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

Would it help to try RenderDoc? https://renderdoc.org/ I guess you're the only one who could understand the output

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

[ddnet.rdc.zip](https://github.com/user-attachments/files/16516328/ddnet.rdc.zip) Here is a recording with the issue when using MoltenVK, I hope you can figure something out with it.

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

What seems to happen is that the graphic is rendered in one vkCmdDrawIndexed, but then disappears in the next immediately: https://github.com/user-attachments/assets/5a1d75fa-bd0c-4a71-a7e6-caa172b1bfac

vulkan_debug: Validation Warning: [ UNASSIGNED-BestPractices-PushConstants ] Object 0: handle = 0x7b5b98722550, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xfd5d8e3f | vkCmdDrawIndexed(): Pipeline uses push constants with 80 bytes, but byte 0 was never set with vkCmdPushConstants.

This is with `gfx_render_thread_count 1`. When I set the Overlay "Clear Before Pass" in RenderDoc the output is correct (the fonts are wrong because I missed around with them as...