spleeter icon indicating copy to clipboard operation
spleeter copied to clipboard

Could the Pandas dependency be removed or made optional?

Open rcgale opened this issue 3 years ago • 1 comments

Description

Pandas is installed as a pip dependency of spleeter. It's adding bloat and complexity, which might not be worth it for for how little it's even used. I don't believe it's referenced at all for a typical "split a song with a pretrained model" workflow.

At a glance, it looks like it could be easily replaced in some instances (e.g. using the native csv reader instead of pd.read_csv(), or using dicts instead of dataframes). If there are places where it's really helping things though, perhaps a local import could be wrapped in a try/except, with a friendly error suggesting that the feature requires pip install pandas==x.x.x?

Thanks for considering!

rcgale avatar Oct 23 '22 21:10 rcgale

Hi @rcgale, Thank you for reporting the issue. Indeed Pandas is quite a soft dependency that could be made optional or replaced. However, this is not a dependency we have had issues with and it's pretty lightweight, so it won't probably be a priority to change this but if some people have trouble with this dependency. Do you have actual issues with this dependency and spleeter?

romi1502 avatar Oct 25 '22 08:10 romi1502