Reed von Redwitz

No feedback from the requester, so I'll just mark this as ready and see what happens. I'm totally open to reworking this, if desired.

@harrysolovay, sorry for the miscommunication. All I was looking for was whether the interface of the config is acceptable to you. I know you were hoping for returning `undefined`, but...

@marvinhagemeister, based on https://github.com/denoland/fresh/issues/1827#issuecomment-1794435015 I guess I should close this. Before I do though: do you see any value in having the `handler` passed to `Deno.serve` configurable/overridable? If not, I'll...

@harrysolovay @lionel-rowe, what's the expected behavior here? I've modified `RouterOptions` so it looks like this: ```ts export interface RouterOptions { trailingSlash?: boolean; ignoreFilePattern?: RegExp; disable404?: boolean; } ``` So you...

Everywhere `connInfo` appears in the source, it's typed as `ServeHandlerInfo`. But both `HandlerContext` and `MiddlewareHandlerContext` are declared with `extends ServeHandlerInfo`. So the `ctx` should always have the local and remote...

Hmmm, that sounds like a different issue to me. I still think this original issue is "already working". Your request sounds like "Fresh should automatically parse `X-Fowarded-For` headers and use...

It seems like #1552 is what we need here.

Well, to elaborate, I was referring to your idea about how to share such a middleware. Currently middleware is specific to your particular project. But you can of course create...

You should go into each fixture and start up the dev server to confirm this isn't causing issues. Perhaps we could even add a test to assert that all the...

I see some changes of `as` -> `satisfies`. I guess this makes sense, but I wonder why just these three places? It seems like there should be a larger audit...