Deepthi Sigireddi

Results 173 comments of Deepthi Sigireddi

This is a little bit of a gray area because on the one hand, we don't "officially" support s3 like non-s3 storage backends. On the other hand, it has worked...

@L3o-pold there's one more thing you should do. Can you run this again with some logging added? Log the context and its deadline in `s3.go` just before we call `Upload`/`UploadWithContext`,...

So the logs tell us that we are not messing up the context in passing it in. AND that it does have a 1 hour timeout. This makes it more...

Then the next thing I can think of is some sort of grpc keep alive timeout. The client (vttablet) is canceling because there's no response within some shorter timeout on...

Here's where we ended up on this https://vitess.slack.com/archives/CMDJ2KFEZ/p1646647235323999?thread_ts=1646094209.117569&cid=CMDJ2KFEZ

@GuptaManan100 @frouioui @verolop what would you recommend?

> I envision this support being controlled by a new tablet flag that allows a list of KVs, such as: --tablet_filter_tags "mysql_version:8.0,instance_type:i3.xlarge". Don't you mean "a new vtgate flag"?

I'd say that this is a big enough code change that back porting to v15 is risky. However, if we have already tested in prod in PlanetScale, it should be...

Not sure which all files require other reviews. We should probably add more code owners for vtadmin proto files - basically duplicate the owners of the proto files. cc @harshit-gangal

Won't this break existing vstream clients? And/or integrations like Debezium?