deeplenstronomy
deeplenstronomy copied to clipboard
deepskies
New profiles in lenstronomy
Lenstronomy has some new profiles so they need to be added to the check.py functionalities.
Even better, check.py should be updated to find all lenstornomy modules programmatically.
@sibirrer mentions that in more recent versions of lenstronomy, all models are now accessible programmatically. E.g. https://github.com/sibirrer/lenstronomy/blob/93c8f1a3e7e7ac9a90adb70aaf8e8c29537ec51b/lenstronomy/LensModel/profile_list_base.py#L6
@rmorgan10 if you want to have a more convenient way to check for it, let me know! There is also the possibility that this kind of check is entirely outsourced to lenstronomy and you don't have to worry about it (at least if you through in a wrong lens model, it will make a raise with a print statement of all available lens models.
Currently, deeplenstronomy checks all the models listed in the configuration file against a list of all lenstronomy models. Unfortunately, that list of lenstronomy modules is hard-coded instead of being determined from lenstronomy itself. All that needs to happen is the hard-coded list needs to be replaced by profile_list_base._SUPPORTED_MODELS, so it's not something that requires changes to lenstornomy.
I may get around to this in fall 2021 when I'm back to maintaining deeplenstronomy, but if someone sees this issue and wants to implement it before me they are more than welcome to.
Check in with SIBirrer about this functionality. Can lenstronomy do this test? is there a way to automatically grab the list of profiles from lenstronomy?
Make it so that we can write the functionality to automatically pull profiles/mapping from lenstronomy code instead of having static lists hard-coded
