haystack
haystack copied to clipboard
deepset-ai
fix: window_size set during run instead of construction
Related Issues
- fixes #8459
Proposed Changes:
How did you test it?
added new unit test
Notes for the reviewer
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Pull Request Test Coverage Report for Build 11461254431
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+0.1%) to 90.468%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| components/retrievers/sentence_window_retriever.py | 1 | 97.96% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 11458137811: | 0.1% |
| Covered Lines: | 7517 |
| Relevant Lines: | 8309 |
💛 - Coveralls
@alperkaya I've reverted some of the changes you did, and added a few more tests - thanks for your contribution.
@davidsbatista @TuanaCelik The issue mentions that "This will make the new sentence window retreval tutorial simpler". So we should follow up on this by simplifying the tutorial https://haystack.deepset.ai/tutorials/42_sentence_window_retriever
