haystack
haystack copied to clipboard
chore: `renaming deserialize_document_store_in_init_params_inplace`
Proposed Changes:
- renaming the
deserialize_document_store_in_init_params_inplaceutil, since it can also work with any other component - I'm using it with the
LLMMetadataExtractor.from_dict()with a generator, currently inhaystack-experimental - see: https://github.com/deepset-ai/haystack-experimental/blob/add-metadata-extractor/haystack_experimental/components/extractors/llm_metadata_extractor.py#L195
How did you test it?
- ran unit tests locally and manual verification
- ran CI tests
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Pull Request Test Coverage Report for Build 12809215757
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 91.292%
| Totals | |
|---|---|
| Change from base Build 12794162077: | 0.0% |
| Covered Lines: | 8838 |
| Relevant Lines: | 9681 |
💛 - Coveralls
NOTE: this is an old PR, I just updated it to see if it has any conflicts - note 100% sure if it still make sense, also OK if we just close it
I will close this for now, we can look into it later if necessary