haystack icon indicating copy to clipboard operation
haystack copied to clipboard

chore: `renaming deserialize_document_store_in_init_params_inplace`

Open davidsbatista opened this issue 1 year ago • 1 comments

Proposed Changes:

  • renaming the deserialize_document_store_in_init_params_inplaceutil, since it can also work with any other component
  • I'm using it with the LLMMetadataExtractor.from_dict() with a generator, currently in haystack-experimental
  • see: https://github.com/deepset-ai/haystack-experimental/blob/add-metadata-extractor/haystack_experimental/components/extractors/llm_metadata_extractor.py#L195

How did you test it?

  • ran unit tests locally and manual verification
  • ran CI tests

Checklist

davidsbatista avatar Sep 17 '24 16:09 davidsbatista

Pull Request Test Coverage Report for Build 12809215757

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.292%

Totals Coverage Status
Change from base Build 12794162077: 0.0%
Covered Lines: 8838
Relevant Lines: 9681

💛 - Coveralls

coveralls avatar Sep 17 '24 17:09 coveralls

NOTE: this is an old PR, I just updated it to see if it has any conflicts - note 100% sure if it still make sense, also OK if we just close it

davidsbatista avatar Jan 16 '25 15:01 davidsbatista

I will close this for now, we can look into it later if necessary

davidsbatista avatar Feb 04 '25 16:02 davidsbatista