deepset-ai
feat: Adding StringJoiner
Related Issues
- fixes https://github.com/deepset-ai/haystack/issues/8353
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Pull Request Test Coverage Report for Build 11595719661
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.01%) to 90.117%
| Totals | |
|---|---|
| Change from base Build 11591750114: | 0.01% |
| Covered Lines: | 7723 |
| Relevant Lines: | 8570 |
💛 - Coveralls
Hey @silvanocerza this is one of the PR's that contains a pipeline behavioral test that fails currently but works in your subgraphs branch.
Once this PR https://github.com/deepset-ai/haystack/pull/8431 is merged then the component in this PR will work and be ready for review.
@dfokina this component will probably go in 2.7.0 and we should create a simple doc page for it.
