haystack
haystack copied to clipboard
deepset-ai
refactor: Rename deserialize_document_store_in_init_parameters
Related Issues
- fixes #8259
Proposed Changes:
How did you test it?
CI
Notes for the reviewer
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:. - I documented my code
- I ran pre-commit hooks and fixed any issue
Thanks for the PR! By convention, we like prefix such functions with _inplace. Could you rename it to deserialize_document_store_in_init_params_inplace instead (and update the docstring to mention the inplace action)?
Pull Request Test Coverage Report for Build 10592528779
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.001%) to 90.2%
| Totals | |
|---|---|
| Change from base Build 10581746861: | -0.001% |
| Covered Lines: | 7004 |
| Relevant Lines: | 7765 |
